Remove FreeLibrary invocations in managed SOS host
#5586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoyosjs
previously approved these changes
Oct 22, 2025
noahfalk
reviewed
Oct 23, 2025
| } | ||
| if (_dacHandle != IntPtr.Zero) | ||
| { | ||
| DataTarget.PlatformFunctions.FreeLibrary(_dacHandle); |
There was a problem hiding this comment.
Do we still want to use cDac with older versions of SOS that won't have this change?
cDAC hosted under NativeAOT could call LoadLibrary() on itself to bump the reference count up. That should prevent the OS from trying to unload it regardless whether SOS calls FreeLibrary().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/runtime#117785, the
runtime-diagnosticspipeline has had intermittent failures due to SOS freeing the DAC/cDAC library and causing a double free race condition.NativeAOT binaries do not support being unloaded, therefore this will be required for future cDAC use.
This change doesn't impact the native host, but in most scenarios the managed host is favored.